code size optimization in BASIC

src/basic/engine/end_of_statement.s

@@ -9,10 +9,7 @@
 
 end_of_statement:
 
-	jsr fetch_character
+	jsr fetch_character_skip_spaces
-
-	cmp #$20                           // check for space
-	beq end_of_statement
 
 	cmp #$3A                           // check for colon
 	beq_16 execute_statements

src/basic/engine/end_of_statement_check.s

@@ -9,6 +9,8 @@
 
 end_of_statement_check:
 
+	// XXX consider optimized version for 46K/56K memory models
+
 	ldy #$00
 
 #if CONFIG_MEMORY_MODEL_60K

src/basic/engine/execute_line_statements.s

@@ -16,9 +16,7 @@ execute_statements:
 
 	// Skip over any white spaces and colons (':')
 !:
-	jsr fetch_character
+	jsr fetch_character_skip_spaces
-	cmp #$20                           // space, can be skipped
-	beq !-
 	cmp #$3A                           // colon, can be skipped
 	beq !-
 	

src/basic/engine/fetch_character_skip_spaces.s

@@ -0,0 +1,15 @@
+// #LAYOUT# STD *       #TAKE
+// #LAYOUT# *   BASIC_0 #TAKE
+// #LAYOUT# *   *       #IGNORE
+
+//
+// Fetches a single character, but skips spaces
+//
+
+fetch_character_skip_spaces:
+
+	jsr fetch_character
+	cmp #$20
+	beq fetch_character_skip_spaces
+
+	rts

src/basic/engine/fetch_uint16.s

@@ -18,9 +18,7 @@ fetch_uint16:
 
 	// Fetch the first character (skip spaces), check if 0-9
 
-	jsr fetch_character
+	jsr fetch_character_skip_spaces
-	cmp #$20
-	beq fetch_uint16
 
 	jsr convert_PETSCII_to_digit
 	bcs fetch_uint16_rts

src/basic/engine/fetch_uint8.s

@@ -16,7 +16,6 @@ fetch_coma_uint8:
 
 fetch_uint8:
 
-	jsr injest_spaces
 	lda #IDX__EV2_0E                             // 'ILLEGAL QUANTITY ERROR'
 	jsr fetch_uint16
 	bcs !+

src/basic/engine/fetch_variable.s

@@ -11,11 +11,8 @@ fetch_variable:
 	sta VARNAM+1
 
 	// Fetch the first character
-!:
-	jsr fetch_character
-	cmp #$20                           // ignore all the spaces
-	beq !-
 
+	jsr fetch_character_skip_spaces
 	jsr is_AZ
 	bcs_16 do_SYNTAX_error
 

src/basic/engine/injest_assign.s

@@ -9,11 +9,9 @@
 
 injest_assign:
 
-	jsr fetch_character
+	jsr fetch_character_skip_spaces
 	cmp #$B2                           // assign operator character
 	beq injest_assign_found
-	cmp #$20                           // space, can always be skipped
-	beq injest_assign
 	
 	// Not found
 	jsr unconsume_character

src/basic/engine/injest_spaces.s

@@ -1,18 +0,0 @@
-// #LAYOUT# STD *       #TAKE
-// #LAYOUT# *   BASIC_0 #TAKE
-// #LAYOUT# *   *       #IGNORE
-
-//
-// Injests all spaces
-//
-
-// XXX get rid of this when proper number parsing is implemented
-
-
-injest_spaces:
-
-	jsr fetch_character
-	cmp #$20                           // space, can be skipped
-	beq injest_spaces
-	
-	jmp unconsume_character

src/basic/wedge/wedge_tape.s

@@ -37,8 +37,7 @@ wedge_arrow_H:
 
 	// Make sure the syntax is correct
 
-	jsr injest_spaces
+	jsr fetch_character_skip_spaces
-	jsr fetch_character
 
 	cmp #$00
 	bne_16 do_SYNTAX_error

src/basic/wedge/wedge_tape_prepare_load.s

@@ -13,8 +13,7 @@ wedge_tape_prepare_load:
 
 	// Make sure the syntax is correct
 
-	jsr injest_spaces
+	jsr fetch_character_skip_spaces
-	jsr fetch_character
 
 	cmp #$00
 	beq wedge_tape_prepare_load_no_filename      // branch if no file name given